Repository navigation
Conversation
The installer refused any layout whose tab bar is a personal clone (content.mod other than "tabs"), and when it did install it placed the Insights button after the tab bar. On Windows and Linux the tab bar draws minimize/maximize/close at its own end (window().buttons), so the button landed after them and the window buttons were no longer last. - accept any mod-backed "tabs" block, not just Herdr's own tabs mod - place the button before the bar on Windows/Linux and after it on macOS, where a leading button would collide with the traffic lights - inject the platform so both placements are covered by tests, and cover a cloned tab bar end to end - update INSTALL.md, README.md and the development guide
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
Summary
tabs.Validation
node --test tests/herdr-insights/toolbar-layout.test.mjs(5 passing)npx eslint herdr-insights/scripts/toolbar.mjs tests/herdr-insights/toolbar-layout.test.mjs tests/herdr-insights/toolbar-install.test.mjs tests/herdr-insights/install-fixtures.mjsherdr-apprunner uses a POSIX shebang, so it cannot run in this environment. The POSIX CI should exercise it.